Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add httpx client for HttpFetchProvider and make it default #590

Merged
merged 3 commits into from
May 30, 2024
Merged

add httpx client for HttpFetchProvider and make it default #590

merged 3 commits into from
May 30, 2024

Conversation

omer9564
Copy link
Contributor

Change the default client for http fetcher provider to httpx to prevent

aiohttp.client_exceptions.ClientPayloadError: Response payload is not completed: <ContentLengthError: 400, message='Not enough data for satisfy content length header.'>

See issue here

@omer9564 omer9564 requested a review from asafc May 30, 2024 14:24
@netlify Netlify
Copy link

netlify bot commented May 30, 2024 •
edited
Loading

✅ Deploy Preview for opal-docs canceled.

Name Link
🔨 Latest commit a0b217f
🔍 Latest deploy log https://app.netlify.com/sites/opal-docs/deploys/665898601fa456000887bded

@omer9564 omer9564 force-pushed the omer/per-10014-add-httpx-http-fetcher branch from 7b42ca7 to f3434a2 Compare May 30, 2024 14:24
@omer9564 omer9564 requested a review from orweis May 30, 2024 14:25
@omer9564 omer9564 force-pushed the omer/per-10014-add-httpx-http-fetcher branch from f3434a2 to 0a1f6a8 Compare May 30, 2024 14:30
@omer9564 omer9564 force-pushed the omer/per-10014-add-httpx-http-fetcher branch from 0a1f6a8 to e54829a Compare May 30, 2024 14:36
asafc
asafc approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@asafc asafc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks ok, fix my comments if you can

packages/opal-common/opal_common/fetcher/providers/http_fetch_provider.py Outdated Show resolved Hide resolved
packages/opal-common/opal_common/fetcher/providers/http_fetch_provider.py Show resolved Hide resolved
@omer9564 omer9564 force-pushed the omer/per-10014-add-httpx-http-fetcher branch from 61ea66b to a0b217f Compare May 30, 2024 15:16
@omer9564 omer9564 merged commit a1f59d5 into master May 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asafc asafc asafc approved these changes

@orweis orweis Awaiting requested review from orweis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omer9564 @asafc